Issue 155584: Merge 20733 - Linux: propagate LD_LIBRARY_PATH through the SUID sandbox....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155584: Merge 20733 - Linux: propagate LD_LIBRARY_PATH through the SUID sandbox.... (Closed)

Created:
11 years, 5 months ago by jon

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, agl, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/194/src/

Visibility:
Public.

Description

Merge 20733 - Linux: propagate LD_LIBRARY_PATH through the SUID sandbox. With the SUID sandbox, certain environment variables (esp LD_LIBRARY_PATH) are cleared for security reasons. This means that the child zygote process isn't run with the correct environment and can fail to start. BUG=16815 TBR=agl@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20781

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	MM	chrome/browser/zygote_host_linux.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	MM	sandbox/linux/suid/sandbox.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 5 months ago (2009-07-15 20:31:43 UTC) #2

On Wed, Jul 15, 2009 at 8:18 PM, <jon@chromium.org> wrote:
> Description:
> Merge 20733 - Linux: propagate LD_LIBRARY_PATH through the SUID sandbox.
> Please review this at http://codereview.chromium.org/155584

LGTM


AGL

Expand Messages | Collapse Messages