Add return param to SkAutoSMalloc::reset() that indicates whether the allocation changed or not.

Add return param to SkAutoSMalloc::reset() that indicates whether the allocation changed or not.

Committed: https://code.google.com/p/skia/source/detail?r=9235

[reed1, 2013-05-21 21:32:33]

Why is this worth it, when the caller can just look at the return-value?

[bsalomon, 2013-05-22 13:34:23]

On 2013/05/21 21:32:33, reed1 wrote:
> Why is this worth it, when the caller can just look at the return-value?

Mike and I talked about this in person, just documenting here.

The problem is that there could be a free() followed by a malloc() that returns
the previous ptr value. In that case there is no guarantee that the memory
contents were preserved.

[bsalomon, 2013-05-22 13:36:37]

Committed patchset #4 manually as r9235 (presubmit successful).