Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 1555743003: [turbofan] Port Crankshaft's weak objects mechanism to TurboFan. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
ulan, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Port Crankshaft's weak objects mechanism to TurboFan. Use the same mechanism that is already available for Crankshaft to not leak all kinds of things in TurboFan generated code. Long-term we will support weakness in a better way, but for now, just use the infrastructure that is already in place to avoid memory leaks via TurboFan generated code. R=jarin@chromium.org, ulan@chromium.org Committed: https://crrev.com/84a88a1bd0e5c1dcdf30d4eeda20628fb3e0bd4b Cr-Commit-Position: refs/heads/master@{#33073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -73 lines) Patch
M src/compiler.cc View 3 chunks +57 lines, -0 lines 0 comments Download
M src/crankshaft/lithium.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/lithium.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +5 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2015-12-31 12:27:04 UTC) #1
Benedikt Meurer
Hey Ulan, Jaro, As discussed two weeks ago, let's first apply what we already have ...
4 years, 11 months ago (2015-12-31 12:28:34 UTC) #2
Jarin
lgtm
4 years, 11 months ago (2016-01-04 06:49:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555743003/1
4 years, 11 months ago (2016-01-04 06:50:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 07:11:53 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 07:12:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a88a1bd0e5c1dcdf30d4eeda20628fb3e0bd4b
Cr-Commit-Position: refs/heads/master@{#33073}

Powered by Google App Engine
This is Rietveld 408576698