Add policy management for on-screen keyboard.

Add policy management for on-screen keyboard.

BUG=341882
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251349

[kevers, 2014-02-10 16:24:30]

Hi Bartosz,

Can you please have a look at this CL.

[bartfab (slow), 2014-02-11 12:41:37]

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
(right):

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc:439:
// Verifies that the default state of the on-screen keyboardaccessibility
Nit: s/keyboardaccessibility/keyboard accessibility/

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/policy/po...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/policy/po...
chrome/browser/policy/policy_browsertest.cc:2428: // Verifies that the on-screen
keyboardaccessibility feature can be controlled
Nit: s/keyboardaccessibility/keyboard accessibility/

https://codereview.chromium.org/155573003/diff/30001/components/policy/resour...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/155573003/diff/30001/components/policy/resour...
components/policy/resources/policy_templates.json:5588: If you set this policy,
users can temporarily override it by enabling or disabling the on-screen
keyboard. However, the user's choice is not persistent and the default is
restored whenever the login screen is shown anew or the user remains idle on the
login screen for a minute.
You forgot to add the pref to recommendation_restorer.cc. Without that, it will
not return to its default automatically.

When you add it to recommendation_restorer.cc, please remember to extend the
unit test for that file accordingly.

[kevers, 2014-02-12 14:54:49]

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
(right):

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc:439:
// Verifies that the default state of the on-screen keyboardaccessibility
On 2014/02/11 12:41:37, bartfab wrote:
> Nit: s/keyboardaccessibility/keyboard accessibility/

Done.

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/policy/po...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/155573003/diff/30001/chrome/browser/policy/po...
chrome/browser/policy/policy_browsertest.cc:2428: // Verifies that the on-screen
keyboardaccessibility feature can be controlled
On 2014/02/11 12:41:37, bartfab wrote:
> Nit: s/keyboardaccessibility/keyboard accessibility/

Done.

https://codereview.chromium.org/155573003/diff/30001/components/policy/resour...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/155573003/diff/30001/components/policy/resour...
components/policy/resources/policy_templates.json:5588: If you set this policy,
users can temporarily override it by enabling or disabling the on-screen
keyboard. However, the user's choice is not persistent and the default is
restored whenever the login screen is shown anew or the user remains idle on the
login screen for a minute.
On 2014/02/11 12:41:37, bartfab wrote:
> You forgot to add the pref to recommendation_restorer.cc. Without that, it
will
> not return to its default automatically.
> 
> When you add it to recommendation_restorer.cc, please remember to extend the
> unit test for that file accordingly.

Done.

[bartfab (slow), 2014-02-12 19:07:45]

lgtm

[kevers, 2014-02-12 19:39:56]

The CQ bit was checked by kevers@chromium.org

[commit-bot: I haz the power, 2014-02-12 19:53:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/155573003/120001

[commit-bot: I haz the power, 2014-02-12 20:36:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-12 20:36:54]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[kevers, 2014-02-12 20:38:52]

The CQ bit was unchecked by kevers@chromium.org

[kevers, 2014-02-12 20:45:33]

+dconnelly@ for policy_templates
+nkostylev@ for login
+asvitkine@ for histograms

[Alexei Svitkine (slow), 2014-02-12 21:07:34]

lgtm for histograms

[Nikita (slow), 2014-02-13 21:44:27]

lgtm

[dconnelly, 2014-02-14 09:37:16]

components/policy/resources/policy_templates.json lgtm

[kevers, 2014-02-14 14:48:29]

The CQ bit was checked by kevers@chromium.org

[commit-bot: I haz the power, 2014-02-14 14:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/155573003/120001

[commit-bot: I haz the power, 2014-02-14 16:40:10]

Change committed as 251349