Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1555653002: Handle some failing DocumentOrderedMap ID lookups across tree removals. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: non-assert buildfix Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp
diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
index 1e2fe05deb8fd395510513ca71914d9918336852..23b1ef678c06389d3f6f841e01d88380ae559342 100644
--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
@@ -586,6 +586,7 @@ PassRefPtrWillBeRawPtr<Node> ContainerNode::removeChild(PassRefPtrWillBeRawPtr<N
{
HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
+ DocumentOrderedMap::RemoveScope treeRemoveScope;
Node* prev = child->previousSibling();
Node* next = child->nextSibling();
@@ -638,6 +639,8 @@ void ContainerNode::parserRemoveChild(Node& oldChild)
oldChild.notifyMutationObserversNodeWillDetach();
HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
+ DocumentOrderedMap::RemoveScope treeRemoveScope;
+
Node* prev = oldChild.previousSibling();
Node* next = oldChild.nextSibling();
removeBetween(prev, next, oldChild);
@@ -685,7 +688,7 @@ void ContainerNode::removeChildren(SubtreeModificationAction action)
#endif
{
HTMLFrameOwnerElement::UpdateSuspendScope suspendWidgetHierarchyUpdates;
-
+ DocumentOrderedMap::RemoveScope treeRemoveScope;
{
EventDispatchForbiddenScope assertNoEventDispatch;
ScriptForbiddenScope forbidScript;

Powered by Google App Engine
This is Rietveld 408576698