Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1555633002: Oilpan: prefinalize CSSCrossfadeValue. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: prefinalize CSSCrossfadeValue. Consistently use prefinalizers for ImageResourceClients, following on from r366092. R=haraken BUG= Committed: https://crrev.com/65d8683de0ca3fb952ba9cbea45bcbc06d91f22f Cr-Commit-Position: refs/heads/master@{#367146}

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.h View 1 2 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 11 months ago (2015-12-30 07:19:44 UTC) #3
haraken
LGTM
4 years, 11 months ago (2015-12-30 07:50:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555633002/40001
4 years, 11 months ago (2015-12-30 08:11:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 11 months ago (2015-12-30 08:22:26 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 08:23:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65d8683de0ca3fb952ba9cbea45bcbc06d91f22f
Cr-Commit-Position: refs/heads/master@{#367146}

Powered by Google App Engine
This is Rietveld 408576698