Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1555613002: Convert Pass()→std::move() in //tools/android (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Yaron, boliu
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //tools/android (╯^□^)╯︵ ❄☃❄ BUG=557422 R=boliu@chromium.org TBR=yfriedman@chromium.org Committed: https://crrev.com/15070771ffb9f1ce5189d138be29170e46e73287 Cr-Commit-Position: refs/heads/master@{#367134}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -43 lines) Patch
M tools/android/forwarder2/daemon.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/android/forwarder2/device_controller.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M tools/android/forwarder2/device_listener.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M tools/android/forwarder2/forwarder.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/android/forwarder2/forwarders_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/host_controller.cc View 6 chunks +13 lines, -14 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
+boliu for general review / sanity check +yfriedman for OWNERS stamp
4 years, 11 months ago (2015-12-29 23:42:52 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555613002/1
4 years, 11 months ago (2015-12-29 23:43:44 UTC) #5
boliu
lgtm
4 years, 11 months ago (2015-12-30 00:08:53 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 00:56:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555613002/1
4 years, 11 months ago (2015-12-30 02:04:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 02:08:56 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 02:09:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15070771ffb9f1ce5189d138be29170e46e73287
Cr-Commit-Position: refs/heads/master@{#367134}

Powered by Google App Engine
This is Rietveld 408576698