Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: Source/bindings/scripts/CodeGeneratorV8.pm

Issue 15556003: Auto-generate V8HTMLFormElement::namedPropertyGetter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Introduce DoNotCheckJSProperty Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/scripts/IDLAttributes.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/CodeGeneratorV8.pm
diff --git a/Source/bindings/scripts/CodeGeneratorV8.pm b/Source/bindings/scripts/CodeGeneratorV8.pm
index 6b3d066d8691aeb5b9eef0fc763e70c5bce82696..decb4894c654311541f52ef3f5f7bcaabcd0955f 100644
--- a/Source/bindings/scripts/CodeGeneratorV8.pm
+++ b/Source/bindings/scripts/CodeGeneratorV8.pm
@@ -3236,10 +3236,12 @@ sub GenerateImplementationNamedPropertyGetter
my $code = "v8::Handle<v8::Value> ${v8ClassName}::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)\n";
$code .= "{\n";
- $code .= " if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
- $code .= " return v8Undefined();\n";
- $code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
- $code .= " return v8Undefined();\n";
+ if (!$namedGetterFunction->signature->extendedAttributes->{"DoNotCheckJSProperty"}) {
+ $code .= " if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())\n";
+ $code .= " return v8Undefined();\n";
+ $code .= " if (info.Holder()->HasRealNamedCallbackProperty(name))\n";
+ $code .= " return v8Undefined();\n";
+ }
$code .= "\n";
$code .= " ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));\n";
$code .= " ${implClassName}* collection = toNative(info.Holder());\n";
@@ -3434,12 +3436,12 @@ v8::Handle<v8::Object> wrap($implClassName* impl, v8::Handle<v8::Object> creatio
END
}
- my $indexer;
my @enabledPerContextFunctions;
my @normalFunctions;
my $needsDomainSafeFunctionSetter = 0;
# Generate methods for functions.
foreach my $function (@{$interface->functions}) {
+ next if $function->signature->name eq "";
GenerateFunction($function, $interface, "");
if ($function->signature->extendedAttributes->{"PerWorldBindings"}) {
GenerateFunction($function, $interface, "ForMainWorld");
@@ -3457,10 +3459,6 @@ END
}
}
- if ($function->signature->name eq "item") {
- $indexer = $function->signature;
- }
-
# If the function does not need domain security check, we need to
# generate an access getter that returns different function objects
# for different calling context.
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/scripts/IDLAttributes.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698