Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 15556002: Refactoring: Generalize CachedSVGDocument for non-SVG use. (Closed)

Created:
7 years, 7 months ago by Hajime Morrita
Modified:
7 years, 7 months ago
CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, darktears, pdr, f(malita), Stephen Chennney, Nate Chapin
Visibility:
Public.

Description

Refactoring: Generalize CachedSVGDocument for non-SVG use. This change generalizes CachedSVGDocument to CachedDocument, which manages Document instead of Document. Currently, CachedDocument implementation accepts only SVG. Further changes will follow. This is a preparation for HTML Imports implementation. BUG=240592 TEST=none R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150857

Patch Set 1 #

Patch Set 2 : Resolved the conflict. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -198 lines) Patch
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/WebKitCSSSVGDocumentValue.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/WebKitCSSSVGDocumentValue.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/loader/cache/CachedDocument.h View 2 chunks +16 lines, -13 lines 0 comments Download
A + Source/core/loader/cache/CachedDocument.cpp View 1 chunk +25 lines, -11 lines 0 comments Download
M Source/core/loader/cache/CachedResourceClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D Source/core/loader/cache/CachedSVGDocument.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/loader/cache/CachedSVGDocument.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
M Source/core/loader/cache/CachedSVGDocumentReference.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderLayerFilterInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGUseElement.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Hajime Morrita
Dimitri, Adam, could you take a look? This change doesn't change behaviour. It's another preparation ...
7 years, 7 months ago (2013-05-21 10:24:13 UTC) #1
abarth-chromium
+japhet LGTM
7 years, 7 months ago (2013-05-21 14:45:28 UTC) #2
dglazkov
This is great!
7 years, 7 months ago (2013-05-21 17:15:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15556002/1
7 years, 7 months ago (2013-05-22 00:50:01 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Source/core/css/resolver/StyleResolver.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-22 00:50:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/15556002/8001
7 years, 7 months ago (2013-05-22 02:13:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=9210
7 years, 7 months ago (2013-05-22 04:02:33 UTC) #7
Hajime Morrita
7 years, 7 months ago (2013-05-22 04:07:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r150857 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698