src/profiler/heap-snapshot-generator.h - Issue 1555553002: [profiler] Implement POC Sampling Heap Profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-snapshot-generator.h

Issue 1555553002: [profiler] Implement POC Sampling Heap Profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cleanup samples when sampling heap profiler is stopped Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/heap-snapshot-generator.h

diff --git a/src/profiler/heap-snapshot-generator.h b/src/profiler/heap-snapshot-generator.h

index 857f2401bf08cc5cccf6fd40bc3e8daadcd138c1..e090ada4638329327742d3c5f34aca8b1a2cecba 100644

--- a/src/profiler/heap-snapshot-generator.h

+++ b/src/profiler/heap-snapshot-generator.h

@@ -8,6 +8,7 @@

#include "include/v8-profiler.h"

#include "src/base/platform/time.h"

#include "src/objects.h"

+#include "src/profiler/heap-profiler.h"

#include "src/profiler/strings-storage.h"

namespace v8 {

@@ -565,8 +566,6 @@ class HeapSnapshotGenerator : public SnapshottingProgressReportingInterface {

DISALLOW_COPY_AND_ASSIGN(HeapSnapshotGenerator);

};

-class OutputStreamWriter;

class HeapSnapshotJSONSerializer {

public:

explicit HeapSnapshotJSONSerializer(HeapSnapshot* snapshot)