src/isolate.cc - Issue 1555553002: [profiler] Implement POC Sampling Heap Profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1555553002: [profiler] Implement POC Sampling Heap Profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: address round 2 comments from alph@ Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 4e42b436b1317022c966370fae99334736912e51..445ee48edb6313f2b7dbf9195d07347f5a50cfcc 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -1919,13 +1919,14 @@ void Isolate::Deinit() {

delete basic_block_profiler_;

basic_block_profiler_ = NULL;

+ delete heap_profiler_;

+ heap_profiler_ = NULL;

heap_.TearDown();

logger_->TearDown();

cancelable_task_manager()->CancelAndWait();

- delete heap_profiler_;

- heap_profiler_ = NULL;

delete cpu_profiler_;

cpu_profiler_ = NULL;