Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/isolate.cc

Issue 1555553002: [profiler] Implement POC Sampling Heap Profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: increase sampling frequency in tests to reduce random chance failure likelihood Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/v8-profiler.h ('K') | « src/heap/spaces.h ('k') | src/profiler/heap-profiler.h » ('j') | src/profiler/heap-profiler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 4e42b436b1317022c966370fae99334736912e51..445ee48edb6313f2b7dbf9195d07347f5a50cfcc 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1919,13 +1919,14 @@ void Isolate::Deinit() {
delete basic_block_profiler_;
basic_block_profiler_ = NULL;
+ delete heap_profiler_;
+ heap_profiler_ = NULL;
+
heap_.TearDown();
logger_->TearDown();
cancelable_task_manager()->CancelAndWait();
- delete heap_profiler_;
- heap_profiler_ = NULL;
delete cpu_profiler_;
cpu_profiler_ = NULL;
« include/v8-profiler.h ('K') | « src/heap/spaces.h ('k') | src/profiler/heap-profiler.h » ('j') | src/profiler/heap-profiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698