Issue 155555: A quick fix for Issue 13711 (the second part)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155555: A quick fix for Issue 13711 (the second part)... (Closed)

Created:
11 years, 5 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Issue 13711 (the second part) Because of a hard-disk problem, I lost the original change. So, I would like to send another change for this fix. This is the second part of the fix for Issue 13711. On non-ASCII keyboards (e.g. Russian and Hebrew), |event->keyval| represents a non-ASCII value that BrowserWindowGtk::HandleAccelerator() cannot handle. To fix this issue, this change uses |event->hardware_keycode| to retrieve its ASCII value before calling BrowserWindowGtk::HandleAccelerator(). BUG=13711 "Alt-D does not work when in editbox" TEST=Type alt+d keys on a Russian keyboard and verify the input focus is moved to an onmibox. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20944

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -1 line)			Patch
	M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View	1	3 chunks	+88 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

11 years, 5 months ago (2009-07-15 16:55:42 UTC) #2

LGTM if this is the same as before.

I'm still a little frightened of these changes.  Do you have any ideas of how we
can create tests to cover all of the input cases?

Expand Messages | Collapse Messages