Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1555543003: Remove GLES2_GPU_SERVICE macro. (Closed)

Created:
4 years, 11 months ago by jbroman
Modified:
4 years, 11 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GLES2_GPU_SERVICE macro. It is defined, but does not seem to be used since it was removed in https://chromium.googlesource.com/chromium/src/+/b9363b27 It was previously used in gles2_cmd_format.h to choose which GL headers to include. Committed: https://crrev.com/e8aebac77edec125d9521285f4c1aa36040a560e Cr-Commit-Position: refs/heads/master@{#367141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
jbroman
Saw this interspersed with #includes, wondered what it did, and it seems it does nothing.
4 years, 11 months ago (2015-12-29 21:13:22 UTC) #3
bajones
Definitely looks like a harmless bit of legacy cruft. LGTM.
4 years, 11 months ago (2015-12-30 04:06:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555543003/1
4 years, 11 months ago (2015-12-30 05:03:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 05:07:35 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 05:08:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8aebac77edec125d9521285f4c1aa36040a560e
Cr-Commit-Position: refs/heads/master@{#367141}

Powered by Google App Engine
This is Rietveld 408576698