third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp - Issue 1555523002: WebGL: remove validation code for vertexAttribPointer and vertexAttribIPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

Issue 1555523002: WebGL: remove validation code for vertexAttribPointer and vertexAttribIPointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove unused validations Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

index 4d2e6bca09a9f8d52f09a6b316b079a0b47f75e8..5f55e256643c921d420eb2e537599f7142af2b5d 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

@@ -90,6 +90,8 @@ WebGLVertexArrayObjectBase::VertexAttribState* WebGLVertexArrayObjectBase::getVe

void WebGLVertexArrayObjectBase::setVertexAttribState(

GLuint index, GLsizei bytesPerElement, GLint size, GLenum type, GLboolean normalized, GLsizei stride, GLintptr offset, WebGLBuffer* buffer)

{

+ if (index >= context()->maxVertexAttribs())

+ return;

GLsizei validatedStride = stride ? stride : bytesPerElement;

VertexAttribState* state = getVertexAttribState(index);