Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp

Issue 1555523002: WebGL: remove validation code for vertexAttribPointer and vertexAttribIPointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix errors found by trybots Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
diff --git a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
index 4d2e6bca09a9f8d52f09a6b316b079a0b47f75e8..7f656ff14a34e415b4c302d92fdb0e61cb785eb5 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
+++ b/third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp
@@ -88,9 +88,8 @@ WebGLVertexArrayObjectBase::VertexAttribState* WebGLVertexArrayObjectBase::getVe
}
void WebGLVertexArrayObjectBase::setVertexAttribState(
- GLuint index, GLsizei bytesPerElement, GLint size, GLenum type, GLboolean normalized, GLsizei stride, GLintptr offset, WebGLBuffer* buffer)
+ GLuint index, WebGLBuffer* buffer)
{
- GLsizei validatedStride = stride ? stride : bytesPerElement;
VertexAttribState* state = getVertexAttribState(index);
if (buffer)
@@ -99,13 +98,6 @@ void WebGLVertexArrayObjectBase::setVertexAttribState(
state->bufferBinding->onDetached(context()->webContext());
state->bufferBinding = buffer;
- state->bytesPerElement = bytesPerElement;
- state->size = size;
- state->type = type;
- state->normalized = normalized;
- state->stride = validatedStride;
- state->originalStride = stride;
- state->offset = offset;
}
void WebGLVertexArrayObjectBase::unbindBuffer(WebGLBuffer* buffer)
@@ -124,12 +116,6 @@ void WebGLVertexArrayObjectBase::unbindBuffer(WebGLBuffer* buffer)
}
}
-void WebGLVertexArrayObjectBase::setVertexAttribDivisor(GLuint index, GLuint divisor)
-{
- VertexAttribState* state = getVertexAttribState(index);
- state->divisor = divisor;
-}
-
DEFINE_TRACE(WebGLVertexArrayObjectBase::VertexAttribState)
{
visitor->trace(bufferBinding);

Powered by Google App Engine
This is Rietveld 408576698