Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 1555523002: WebGL: remove validation code for vertexAttribPointer and vertexAttribIPointer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unused validations Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "modules/webgl/WebGLExtension.h" 8 #include "modules/webgl/WebGLExtension.h"
9 #include "modules/webgl/WebGLRenderingContextBase.h" 9 #include "modules/webgl/WebGLRenderingContextBase.h"
10 10
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 bool checkAndTranslateAttachments(const char* functionName, GLenum, const Ve ctor<GLenum>&, Vector<GLenum>&); 219 bool checkAndTranslateAttachments(const char* functionName, GLenum, const Ve ctor<GLenum>&, Vector<GLenum>&);
220 220
221 /* WebGLRenderingContextBase overrides */ 221 /* WebGLRenderingContextBase overrides */
222 unsigned getMaxWebGLLocationLength() const override { return 1024; }; 222 unsigned getMaxWebGLLocationLength() const override { return 1024; };
223 bool validateCapability(const char* functionName, GLenum) override; 223 bool validateCapability(const char* functionName, GLenum) override;
224 bool validateBufferTarget(const char* functionName, GLenum target) override; 224 bool validateBufferTarget(const char* functionName, GLenum target) override;
225 bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, Web GLBuffer*) override; 225 bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, Web GLBuffer*) override;
226 WebGLTexture* validateTextureBinding(const char* functionName, GLenum target , bool useSixEnumsForCubeMap) override; 226 WebGLTexture* validateTextureBinding(const char* functionName, GLenum target , bool useSixEnumsForCubeMap) override;
227 bool validateFramebufferTarget(GLenum target) override; 227 bool validateFramebufferTarget(GLenum target) override;
228 bool validateReadPixelsFormatAndType(GLenum format, GLenum type) override; 228 bool validateReadPixelsFormatAndType(GLenum format, GLenum type) override;
229 bool validateVertexAttribPointerTypeAndSize(GLenum type, GLint size) overrid e;
230 229
231 DOMArrayBufferView::ViewType readPixelsExpectedArrayBufferViewType(GLenum ty pe) override; 230 DOMArrayBufferView::ViewType readPixelsExpectedArrayBufferViewType(GLenum ty pe) override;
232 WebGLFramebuffer* getFramebufferBinding(GLenum target) override; 231 WebGLFramebuffer* getFramebufferBinding(GLenum target) override;
233 GLint getMaxTextureLevelForTarget(GLenum target) override; 232 GLint getMaxTextureLevelForTarget(GLenum target) override;
234 void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internal format, GLsizei width, GLsizei height, const char* functionName) override; 233 void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internal format, GLsizei width, GLsizei height, const char* functionName) override;
235 GLenum boundFramebufferColorFormat() override; 234 GLenum boundFramebufferColorFormat() override;
236 const WebGLSamplerState* getTextureUnitSamplerState(GLenum target, GLuint un it) const override; 235 const WebGLSamplerState* getTextureUnitSamplerState(GLenum target, GLuint un it) const override;
237 236
238 // Helper function to validate the target for compressedTex{Sub}Image3D. 237 // Helper function to validate the target for compressedTex{Sub}Image3D.
239 bool validateTexFunc3DTarget(const char* functionName, GLenum target); 238 bool validateTexFunc3DTarget(const char* functionName, GLenum target);
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 GLint m_unpackSkipImages; 278 GLint m_unpackSkipImages;
280 }; 279 };
281 280
282 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context, 281 DEFINE_TYPE_CASTS(WebGL2RenderingContextBase, CanvasRenderingContext, context,
283 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 282 context->is3d() && WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
284 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ; 283 context.is3d() && WebGLRenderingContextBase::getWebGLVersion(&context) >= 2) ;
285 284
286 } // namespace blink 285 } // namespace blink
287 286
288 #endif 287 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698