WebGL: remove validation code for vertexAttribPointer and vertexAttribIPointer

third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebGLVertexArrayObjectBase_h
 #define WebGLVertexArrayObjectBase_h
 
 #include "modules/webgl/WebGLBuffer.h"
 #include "modules/webgl/WebGLContextObject.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class WebGLVertexArrayObjectBase : public WebGLContextObject {
 public:
     enum VaoType {
         VaoTypeDefault,
         VaoTypeUser,
     };
 
     ~WebGLVertexArrayObjectBase() override;
 
     Platform3DObject object() const { return m_object; }
 
     // Cached values for vertex attrib range checks
     class VertexAttribState final : public GarbageCollected<VertexAttribState> {

[Zhenyao Mo, 2016/01/05 21:13:21]

Do we still need this class?  Can't we just put bufferBinding as a direct member
of WebGLVertexArrayObjectBase?

[Ken Russell (switch to Gerrit), 2016/01/06 03:55:27]

It looks to me like m_vertexAttribState could be changed to:

HeapVector<Member<WebGLBuffer>> m_boundArrayBuffers;

and yes, that this class could be removed.

[yunchao, 2016/01/06 17:31:42]

Thanks for your review, Zhenyao and Ken. I have tried to remove
VertexAttribState, but It need some change in getVertexAttrib at that time.
Please see the other comment.

     public:
-        VertexAttribState()
-            : enabled(false)
-            , bytesPerElement(0)
-            , size(4)
-            , type(GL_FLOAT)
-            , normalized(false)
-            , stride(16)
-            , originalStride(0)
-            , offset(0)
-            , divisor(0)
-        {
-        }
+        VertexAttribState() {}
 
         DECLARE_TRACE();
 
-        bool enabled;
         Member<WebGLBuffer> bufferBinding;
-        GLsizei bytesPerElement;
-        GLint size;
-        GLenum type;
-        bool normalized;
-        GLsizei stride;
-        GLsizei originalStride;
-        GLintptr offset;
-        GLuint divisor;
     };
 
     bool isDefaultObject() const { return m_type == VaoTypeDefault; }
 
     bool hasEverBeenBound() const { return object() && m_hasEverBeenBound; }
     void setHasEverBeenBound() { m_hasEverBeenBound = true; }
 
     WebGLBuffer* boundElementArrayBuffer() const { return m_boundElementArrayBuffer; }
     void setElementArrayBuffer(WebGLBuffer*);
 
     VertexAttribState* getVertexAttribState(size_t);
-    void setVertexAttribState(GLuint, GLsizei, GLint, GLenum, GLboolean, GLsizei, GLintptr, WebGLBuffer*);
+    void setVertexAttribState(GLuint, WebGLBuffer*);
     void unbindBuffer(WebGLBuffer*);
-    void setVertexAttribDivisor(GLuint index, GLuint divisor);
 
     DECLARE_VIRTUAL_TRACE();
 
 protected:
     WebGLVertexArrayObjectBase(WebGLRenderingContextBase*, VaoType);
 
 private:
     void dispatchDetached(WebGraphicsContext3D*);
     bool hasObject() const override { return m_object != 0; }
     void deleteObjectImpl(WebGraphicsContext3D*) override;
 
     Platform3DObject m_object;
 
     VaoType m_type;
     bool m_hasEverBeenBound;
     bool m_destructionInProgress;
     Member<WebGLBuffer> m_boundElementArrayBuffer;
     HeapVector<Member<VertexAttribState>> m_vertexAttribState;
 };
 
 } // namespace blink
 
 #endif // WebGLVertexArrayObjectBase_h