Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: content/browser/media/capture/web_contents_video_capture_device.cc

Issue 1555513004: Fix crash when view is already deleted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/media/capture/web_contents_video_capture_device.cc
diff --git a/content/browser/media/capture/web_contents_video_capture_device.cc b/content/browser/media/capture/web_contents_video_capture_device.cc
index d69a0bc6ce3c8849d25d2cfadca262cac8d13c2d..c2a9090eeba1218deb63ca49939bec49ab202967 100644
--- a/content/browser/media/capture/web_contents_video_capture_device.cc
+++ b/content/browser/media/capture/web_contents_video_capture_device.cc
@@ -443,8 +443,10 @@ ContentCaptureSubscription::ContentCaptureSubscription(
// TODO(isheriff): Needs implementation on non-aura platforms.
// https://crbug.com/567735
#if defined(USE_AURA)
- window_activity_tracker_.reset(
- new content::WindowActivityTrackerAura(view->GetNativeView()));
+ if (view) {
miu 2015/12/30 00:22:40 Possible clean-up in future CL: Looks like we shou
Irfan 2015/12/30 00:32:12 I like not instantiating ContentCaptureSubscriptio
+ window_activity_tracker_.reset(
+ new content::WindowActivityTrackerAura(view->GetNativeView()));
+ }
#endif
timer_subscriber_.reset(new FrameSubscriber(
media::VideoCaptureOracle::kTimerPoll, oracle_proxy, &delivery_log_,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698