Fix crash when view is already deleted

Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG=572577
Committed: https://crrev.com/5c3c13aa9bd3d716611e9458fc08b3c017f9be06
Cr-Commit-Position: refs/heads/master@{#367123}

[Irfan, 2015-12-29 21:54:44]

Description was changed from

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577
==========

to

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577
==========

[Irfan, 2015-12-29 21:54:44]

isheriff@chromium.org changed reviewers:
+ miu@chromium.org

[miu, 2015-12-30 00:22:40]

lgtm

https://codereview.chromium.org/1555513004/diff/1/content/browser/media/captu...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/1555513004/diff/1/content/browser/media/captu...
content/browser/media/capture/web_contents_video_capture_device.cc:446: if
(view) {
Possible clean-up in future CL: Looks like we should just check the view at the
top of this method and return early if nullptr.  Or, maybe the caller should not
instantiate a ContentCaptureSubscription if the view is null?

[Irfan, 2015-12-30 00:32:09]

The CQ bit was checked by isheriff@chromium.org

[Irfan, 2015-12-30 00:32:13]

https://codereview.chromium.org/1555513004/diff/1/content/browser/media/captu...
File content/browser/media/capture/web_contents_video_capture_device.cc (right):

https://codereview.chromium.org/1555513004/diff/1/content/browser/media/captu...
content/browser/media/capture/web_contents_video_capture_device.cc:446: if
(view) {
On 2015/12/30 00:22:40, miu wrote:
> Possible clean-up in future CL: Looks like we should just check the view at
the
> top of this method and return early if nullptr.  Or, maybe the caller should
not
> instantiate a ContentCaptureSubscription if the view is null?

I like not instantiating ContentCaptureSubscription when view is null, but I
leave this as-is right now.

[commit-bot: I haz the power, 2015-12-30 00:33:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555513004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555513004/1

[commit-bot: I haz the power, 2015-12-30 01:27:34]

Description was changed from

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577
==========

to

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577
==========

[commit-bot: I haz the power, 2015-12-30 01:27:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-30 01:28:18]

Description was changed from

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577
==========

to

==========
Fix crash when view is already deleted

ContentCaptureSubscription should only create a window activity tracker
if the RenderWidgetHostView on the source is not deleted.

BUG= 572577

Committed: https://crrev.com/5c3c13aa9bd3d716611e9458fc08b3c017f9be06
Cr-Commit-Position: refs/heads/master@{#367123}
==========

[commit-bot: I haz the power, 2015-12-30 01:28:19]

Patchset 1 (id:??) landed as
https://crrev.com/5c3c13aa9bd3d716611e9458fc08b3c017f9be06
Cr-Commit-Position: refs/heads/master@{#367123}