[Android WebView] Forbid launching of two browser processes in the app

[Android WebView] Forbid launching of two browser processes in the app

Use FileLock in the data directory to enforce exclusive access to it.

Attempting to share the data directory between two browser processes
will most likely lead to data corruption.

BUG=558377
Committed: https://crrev.com/079328852c8cd8aab87d8cf6811fe371f4c65307
Cr-Commit-Position: refs/heads/master@{#367120}

[mnaganov (inactive), 2015-12-29 20:03:22]

mnaganov@chromium.org changed reviewers:
+ sgurun@chromium.org

[mnaganov (inactive), 2015-12-29 20:03:23]

PTAL! Hopefully the last code for this year :)

[sgurun-gerrit only, 2015-12-29 23:58:56]

On 2015/12/29 20:03:23, mnaganov wrote:
> PTAL! Hopefully the last code for this year :)

lgtm

[sgurun-gerrit only, 2015-12-29 23:59:03]

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
File
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
(right):

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java:20:
* This is an activity for imitating a second browser process in the application.
nit: s/activity/service/

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java:34:
} catch (Exception e) {
himm, I think findbugs will barf for the blanket exception.

[mnaganov (inactive), 2015-12-30 00:13:03]

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
File
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
(right):

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java:20:
* This is an activity for imitating a second browser process in the application.
On 2015/12/29 23:59:03, sgurun wrote:
> nit: s/activity/service/

Done.

https://codereview.chromium.org/1555513003/diff/1/android_webview/test/shell/...
android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java:34:
} catch (Exception e) {
On 2015/12/29 23:59:03, sgurun wrote:
> himm, I think findbugs will barf for the blanket exception.

Looks like it looks good for findbugs. However, it barked at the hardcoded
absolute path below, so it was a good suggestion to run it :)

[mnaganov (inactive), 2015-12-30 00:13:38]

The CQ bit was checked by mnaganov@chromium.org

[mnaganov (inactive), 2015-12-30 00:13:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org
Link to the patchset: https://codereview.chromium.org/1555513003/#ps20001
(title: "Comments addressed")

[commit-bot: I haz the power, 2015-12-30 00:14:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555513003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555513003/20001

[commit-bot: I haz the power, 2015-12-30 00:37:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-30 00:38:15]

Description was changed from

==========
[Android WebView] Forbid launching of two browser processes in the app

Use FileLock in the data directory to enforce exclusive access to it.

Attempting to share the data directory between two browser processes
will most likely lead to data corruption.

BUG=558377
==========

to

==========
[Android WebView] Forbid launching of two browser processes in the app

Use FileLock in the data directory to enforce exclusive access to it.

Attempting to share the data directory between two browser processes
will most likely lead to data corruption.

BUG=558377

Committed: https://crrev.com/079328852c8cd8aab87d8cf6811fe371f4c65307
Cr-Commit-Position: refs/heads/master@{#367120}
==========

[commit-bot: I haz the power, 2015-12-30 00:38:16]

Patchset 2 (id:??) landed as
https://crrev.com/079328852c8cd8aab87d8cf6811fe371f4c65307
Cr-Commit-Position: refs/heads/master@{#367120}