Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: net/spdy/spdy_stream.h

Issue 15555003: [SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index 8ead4e6686b075dc546bdad1cf3b695efb0fbe76..b9ecfe992623956bb7e2d1bd5d3b79f51e0e1f1c 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -60,10 +60,14 @@ class NET_EXPORT_PRIVATE SpdyStream {
// Returns true if no more data to be sent after SYN frame.
virtual SpdySendStatus OnSendHeadersComplete() = 0;
- // Called when stream is ready to send data.
- // Returns network error code. OK when it successfully sent data.
- // ERR_IO_PENDING when performing operation asynchronously.
- virtual int OnSendBody() = 0;
+ // Called when the stream is ready to send body data. The
+ // delegate must call QueueStreamData() on the stream, either
+ // immediately or asynchronously (e.g., if the data to be send has
+ // to be read asynchronously).
+ //
+ // Called only when OnSendHeadersComplete() or
+ // OnSendBodyComplete() returns MORE_DATA_TO_SEND.
+ virtual void OnSendBody() = 0;
// Called when body data has been sent. |bytes_sent| is the number
// of bytes that has been sent (may be zero). Must return whether
« no previous file with comments | « net/spdy/spdy_session_spdy3_unittest.cc ('k') | net/spdy/spdy_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698