Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: net/spdy/spdy_http_stream.h

Issue 15555003: [SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typo Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_http_stream.h
diff --git a/net/spdy/spdy_http_stream.h b/net/spdy/spdy_http_stream.h
index bfb5076b18c457a3a57f68d9b50d260086f5cb00..5f405d36feed30c055e05c747497a24e4a59fbcc 100644
--- a/net/spdy/spdy_http_stream.h
+++ b/net/spdy/spdy_http_stream.h
@@ -85,7 +85,7 @@ class NET_EXPORT_PRIVATE SpdyHttpStream : public SpdyStream::Delegate,
// SpdyStream::Delegate implementation.
virtual SpdySendStatus OnSendHeadersComplete() OVERRIDE;
- virtual int OnSendBody() OVERRIDE;
+ virtual void OnSendBody() OVERRIDE;
virtual SpdySendStatus OnSendBodyComplete(size_t bytes_sent) OVERRIDE;
virtual int OnResponseReceived(const SpdyHeaderBlock& response,
base::Time response_time,
@@ -98,15 +98,21 @@ class NET_EXPORT_PRIVATE SpdyHttpStream : public SpdyStream::Delegate,
private:
void OnStreamCreated(const CompletionCallback& callback, int rv);
- // Reads the data (whether chunked or not) from the request body stream and
- // sends the data by calling WriteStreamData on the underlying SpdyStream.
- int SendData();
+ // Reads the data (whether chunked or not) from the request body
+ // stream and sends it. The read and subsequent sending may happen
+ // asynchronously.
+ void ReadAndSendRequestBodyData();
+
+ // Called when data has just been read from the request body stream;
+ // does the actual sending of data.
+ void OnRequestBodyReadCompleted(int status);
+
+ // Queues some request body data to be sent.
+ void SendRequestBodyData();
// Call the user callback.
void DoCallback(int rv);
- int OnRequestBodyReadCompleted(int status);
-
void ScheduleBufferedReadCallback();
// Returns true if the callback is invoked.
« no previous file with comments | « no previous file | net/spdy/spdy_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698