net/spdy/spdy_stream_spdy3_unittest.cc - Issue 15555003: [SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream_spdy3_unittest.cc

Issue 15555003: [SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove return value Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_stream_spdy3_unittest.cc

diff --git a/net/spdy/spdy_stream_spdy3_unittest.cc b/net/spdy/spdy_stream_spdy3_unittest.cc

index 2c802118d3d80a16b1473b591bd3062dca0a1e42..a760034f19ed2282e6138e5bae10ca003bc69117 100644

--- a/net/spdy/spdy_stream_spdy3_unittest.cc

+++ b/net/spdy/spdy_stream_spdy3_unittest.cc

@@ -479,7 +479,7 @@ TEST_F(SpdyStreamSpdy3Test, ResumeAfterSendWindowSizeIncrease) {

std::min(kMaxSpdyFrameChunkSize, stream->send_window_size()));

}

- EXPECT_EQ(ERR_IO_PENDING, delegate.OnSendBody());

+ delegate.OnSendBody();

EXPECT_TRUE(stream->send_stalled_by_flow_control());

@@ -563,7 +563,7 @@ TEST_F(SpdyStreamSpdy3Test, ResumeAfterSendWindowSizeAdjust) {

std::min(kMaxSpdyFrameChunkSize, stream->send_window_size()));

}

- EXPECT_EQ(ERR_IO_PENDING, delegate.OnSendBody());

+ delegate.OnSendBody();

EXPECT_TRUE(stream->send_stalled_by_flow_control());