[SPDY] Remove SpdyStream::Delegate::OnSendBody()'s return value

net/spdy/spdy_proxy_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_proxy_client_socket.h"
 
 #include <algorithm>  // min
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 450 matching lines @@
 SpdySendStatus SpdyProxyClientSocket::OnSendHeadersComplete() {
   DCHECK_EQ(next_state_, STATE_SEND_REQUEST_COMPLETE);
 
   OnIOComplete(OK);
 
   // We return true here so that we send |spdy_stream_| into
   // STATE_OPEN (ala WebSockets).
   return NO_MORE_DATA_TO_SEND;
 }
 
-int SpdyProxyClientSocket::OnSendBody() {
+void SpdyProxyClientSocket::OnSendBody() {
   // Because we use |spdy_stream_| via STATE_OPEN (ala WebSockets)
-  // OnSendBody() should never be called.
-  NOTREACHED();
-  return ERR_UNEXPECTED;
+  // OnSendBody() must never be called.
+  CHECK(false);

[Ryan Hamilton, 2013/05/22 03:17:30]

CHECK(false)?  This is pretty hardcore.  Are you sure you want to crash the
user's browser in this case?

[akalin, 2013/05/22 08:40:05]

Yeah, I think it's for the best. If this were originally a CHECK(false), I think
we would have caught this bug much sooner!

I don't think I've ever regretted converting something to a CHECK(), as it
provides clear feedback on what goes wrong via canary/dev channel. The worst
thing that could happen is that it starts triggering on the stable channel, but
I think we're pretty good at catching things before they get that far.

 }
 
 SpdySendStatus SpdyProxyClientSocket::OnSendBodyComplete(
     size_t /*bytes_sent*/) {
   // Because we use |spdy_stream_| via STATE_OPEN (ala WebSockets)
-  // OnSendBodyComplete() should never be called.
-  NOTREACHED();
+  // OnSendBodyComplete() must never be called.
+  CHECK(false);

[Ryan Hamilton, 2013/05/22 03:17:30]

ditto

[akalin, 2013/05/22 08:40:05]

ditto.

   return NO_MORE_DATA_TO_SEND;
 }
 
 int SpdyProxyClientSocket::OnResponseReceived(
     const SpdyHeaderBlock& response,
     base::Time response_time,
     int status) {
   // If we've already received the reply, existing headers are too late.
   // TODO(mbelshe): figure out a way to make HEADERS frames useful after the
   //                initial response.
@@ skipping 79 matching lines @@
   } else if (!read_callback_.is_null()) {
     // If we have a read_callback_, the we need to make sure we call it back.
     OnDataReceived(scoped_ptr<SpdyBuffer>());
   }
   // This may have been deleted by read_callback_, so check first.
   if (weak_ptr && !write_callback.is_null())
     write_callback.Run(ERR_CONNECTION_CLOSED);
 }
 
 }  // namespace net