Issue 155547: Don't try to set transparency on pixbufs that don't have any transparency....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155547: Don't try to set transparency on pixbufs that don't have any transparency.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't try to set transparency on pixbufs that don't have any transparency channel. Also add DCHECK to make sure the assumption rowstride >= width * 4 is true. The reason this didn't cause any crashes or graphical corruption is because the non-transparent images don't have any white in them (luckily we are not making a browser for an ipod). BUG=16749 TEST=valgrind the browser, open find bar Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20701

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/browser/gtk/nine_box.cc	View		1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, thanks for the quick turnaround!

Expand Messages | Collapse Messages