Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1555443002: clang update.py: Use a gcc4.8.2 that was prebuilt on Precise. (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
hans
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang update.py/linux: Use a gcc4.8.2 that was prebuilt on Precise. That way, the libstdc++ that's used by default should work on the bots. Before this change, one had to pass --gcc-toolchain pointing to a precise-built gcc when building linux clang binaries. BUG=509739 TBR=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/102a658b53b01380c102de0519c1844eaecd0850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 12 months ago (2015-12-29 00:02:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555443002/1
4 years, 12 months ago (2015-12-29 00:03:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/102a658b53b01380c102de0519c1844eaecd0850 Cr-Commit-Position: refs/heads/master@{#367026}
4 years, 12 months ago (2015-12-29 00:09:06 UTC) #5
Nico
Committed patchset #1 (id:1) manually as 102a658b53b01380c102de0519c1844eaecd0850 (presubmit successful).
4 years, 12 months ago (2015-12-29 00:09:55 UTC) #7
hans
4 years, 11 months ago (2015-12-29 08:59:59 UTC) #8
Message was sent while issue was closed.
lgtm, hope this works

Powered by Google App Engine
This is Rietveld 408576698