Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1555333002: Add null check for bmp->tex result in SkImageFilter::filterInputGpu (Closed)

Created:
4 years, 11 months ago by bsalomon
Modified:
4 years, 11 months ago
Reviewers:
Stephen White
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add unit test #

Patch Set 3 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M src/core/SkImageFilter.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
bsalomon
4 years, 11 months ago (2016-01-05 14:21:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555333002/1
4 years, 11 months ago (2016-01-05 14:22:05 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 14:36:49 UTC) #7
Stephen White
On 2016/01/05 14:36:49, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 11 months ago (2016-01-05 15:07:29 UTC) #8
bsalomon
On 2016/01/05 15:07:29, Stephen White wrote: > On 2016/01/05 14:36:49, commit-bot: I haz the power ...
4 years, 11 months ago (2016-01-05 15:28:07 UTC) #9
Stephen White
On 2016/01/05 15:28:07, bsalomon wrote: > On 2016/01/05 15:07:29, Stephen White wrote: > > On ...
4 years, 11 months ago (2016-01-05 15:30:10 UTC) #10
bsalomon
Thanks! Unit test added. PTAL.
4 years, 11 months ago (2016-01-05 16:02:03 UTC) #11
Stephen White
LGTM
4 years, 11 months ago (2016-01-05 16:10:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555333002/40001
4 years, 11 months ago (2016-01-05 16:21:22 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 16:39:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/45eefcfec26ee48c0b2ee1d316aae3c3dc529145

Powered by Google App Engine
This is Rietveld 408576698