Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1555233002: Encode number of type parameters in prelinked summary. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Encode number of type parameters in prelinked summary. In a future CL, this should allow the element model to be resynthesized from a summary more efficiently, since it won't be necessary to consult the referenced elements when resynthesizing a FunctionTypeImpl. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e626abcebc2c0ad6eb947790063fea6efda2991d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -20 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 3 chunks +15 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 16 chunks +55 lines, -17 lines 2 comments Download
M pkg/analyzer/tool/summary/idl.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-04 22:55:33 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1555233002/diff/1/pkg/analyzer/test/src/summary/summary_test.dart File pkg/analyzer/test/src/summary/summary_test.dart (right): https://codereview.chromium.org/1555233002/diff/1/pkg/analyzer/test/src/summary/summary_test.dart#newcode853 pkg/analyzer/test/src/summary/summary_test.dart:853: test_class_reference_generic() { Does this, or should this, also ...
4 years, 11 months ago (2016-01-04 23:20:46 UTC) #3
Paul Berry
https://codereview.chromium.org/1555233002/diff/1/pkg/analyzer/test/src/summary/summary_test.dart File pkg/analyzer/test/src/summary/summary_test.dart (right): https://codereview.chromium.org/1555233002/diff/1/pkg/analyzer/test/src/summary/summary_test.dart#newcode853 pkg/analyzer/test/src/summary/summary_test.dart:853: test_class_reference_generic() { On 2016/01/04 23:20:46, Brian Wilkerson wrote: > ...
4 years, 11 months ago (2016-01-04 23:34:04 UTC) #4
Paul Berry
4 years, 11 months ago (2016-01-04 23:37:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e626abcebc2c0ad6eb947790063fea6efda2991d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698