Middle clicks on all fragment links open in new tab.

Middle clicks on all fragment links open in new tab.

Middle clicking on an anchor tag that points to an
in-doc fragment should result in a new background
tab being opened.  Before this change, we were
overriding this behavior to cause a middle click to
behave like a left click.  This patch allows middle
clicks to function similar to the behavior seen in
Firefox and Safari.

No change in behavior should be seen by users for left
clicks on anchor tags that refer to in-doc fragments.

While testing, I see at times issues due to scrolling
within the tab to the correct fragment identifier or
start of the page.  This has already been identified in
issues such as 9319, so I'm ignoring that for now.

BUG=2913
TEST=Load Wikipedia, visit a page with many subheadings,
left click on a subheading, verify the current page
scrolls to the correct heading.  Click back, verify you
are taken back to your original position.  Middle click
on the same subheading, verify a new tab is loaded in
the background that is scrolled to the correct heading.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20674

[Peter Kasting, 2009-07-14 20:07:35]

http://codereview.chromium.org/155522/diff/1/2
File webkit/glue/webframeloaderclient_impl.cc (right):

http://codereview.chromium.org/155522/diff/1/2#newcode937
Line 937: if (disposition != IGNORE_ACTION) {
Drive-by: You can condense this block even more if you do this:
if (disposition == CURRENT_TAB) {
  policy_action = PolicyUse;
} else if (disposition == SAVE_TO_DISK) {
  policy_action = PolicyDownload;
} else {
  if (disposition != IGNORE_ACTION) {
    ...
  }
  policy_action = PolicyIgnore;
}

[darin (slow to review), 2009-07-14 21:41:00]

LGTM

[chase, 2009-07-14 21:49:52]

Taking into account pkasting's review.