Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1555213002: fix #25305, DeclarationResolver.visitTypeParameter now handles generic methods (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, Leaf, devoncarew
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #25305, DeclarationResolver.visitTypeParameter now handles generic methods R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/fcc84d1a03fb80b63637a8edf18698c9c17ab0a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -20 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 6 chunks +75 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
This was found by Flutter: https://github.com/dart-lang/sdk/issues/25305
4 years, 11 months ago (2016-01-04 22:49:03 UTC) #2
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-04 23:05:11 UTC) #3
Jennifer Messerly
4 years, 11 months ago (2016-01-04 23:23:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcc84d1a03fb80b63637a8edf18698c9c17ab0a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698