Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issue 1555153003: Another round of PDF plugin cleanups. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Another round of PDF plugin cleanups. - Use for-range loops / std::vector::insert() when possible. - Mark methods const. - Use std::{string,vector}::empty() instead of size() when possible. Committed: https://crrev.com/ccb5fc8ff322c02db30604d0df003626eaff5f34 Cr-Commit-Position: refs/heads/master@{#367486}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -158 lines) Patch
M pdf/chunk_stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M pdf/chunk_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 4 chunks +13 lines, -13 lines 0 comments Download
M pdf/paint_aggregator.cc View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
M pdf/paint_manager.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 25 chunks +85 lines, -95 lines 0 comments Download
M pdf/pdfium/pdfium_page.h View 3 chunks +4 lines, -3 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 8 chunks +21 lines, -24 lines 0 comments Download
M pdf/pdfium/pdfium_range.h View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_range.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Lei Zhang
Hopefully the last round for a while.
4 years, 11 months ago (2016-01-05 00:43:59 UTC) #3
raymes
lgtm
4 years, 11 months ago (2016-01-05 04:18:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555153003/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555153003/30001
4 years, 11 months ago (2016-01-05 05:27:12 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 11 months ago (2016-01-05 05:33:01 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 05:33:54 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ccb5fc8ff322c02db30604d0df003626eaff5f34
Cr-Commit-Position: refs/heads/master@{#367486}

Powered by Google App Engine
This is Rietveld 408576698