Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 155513005: NaCl: Update revision in DEPS, r12705 -> r12710 (Closed)

Created:
6 years, 10 months ago by Mark Seaborn
Modified:
6 years, 10 months ago
Reviewers:
hidehiko, bradn
CC:
chromium-reviews, Derek Schuff, JF, native-client-reviews_googlegroups.com, teravest
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r12705 -> r12710 This pulls in the following Native Client changes: r12706: (jfb) Update TOOL_REVISIONS for PNaCl r12686->r12703 r12707: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r12708: (mseaborn) Remove unneeded ARG_REGISTERS mapping from syscall handler generator r12709: (teravest) NaCl: Clean up ReverseService::OpenManifestEntry. r12710: (mseaborn) Expose NaClAppSetDesc() to Chromium for use at startup BUG=none TEST=browser_tests and nacl_integration R=bradnelson@google.com, hidehiko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
6 years, 10 months ago (2014-02-05 23:11:35 UTC) #1
bradn
lgtm
6 years, 10 months ago (2014-02-05 23:12:40 UTC) #2
hidehiko
lgtm Assuming try bots pass. Thank you for updating.
6 years, 10 months ago (2014-02-06 01:41:38 UTC) #3
hidehiko
On 2014/02/06 01:41:38, hidehiko wrote: > lgtm > > Assuming try bots pass. Thank you ...
6 years, 10 months ago (2014-02-06 04:37:14 UTC) #4
hidehiko
The CQ bit was checked by hidehiko@chromium.org
6 years, 10 months ago (2014-02-06 04:37:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/155513005/1
6 years, 10 months ago (2014-02-06 04:39:57 UTC) #6
Mark Seaborn
6 years, 10 months ago (2014-02-06 04:47:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r249274 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698