Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1555073003: Replace ResultProvider with 'aboutToComputeResult'. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Replace ResultProvider with 'aboutToComputeResult'. This way we would be able to redirect to the SDK context, or get some results from packages. Setting ResultProvider into AnalysisDriver does not allow us to do this. My quick and dirty experiment with using SDK summaries is broken now, but I'm going to start updating actual SdkAnalysisContext using summaries, if the bundle exists in the SDK. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a2d615e52a505db2206c7971aa2d9e1dc8c7e87f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -74 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 6 chunks +7 lines, -36 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 17 chunks +22 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-04 17:52:12 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-04 18:03:02 UTC) #2
scheglov
4 years, 11 months ago (2016-01-04 18:19:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a2d615e52a505db2206c7971aa2d9e1dc8c7e87f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698