Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1555073002: Revert element hierarchy to its original form (Closed)

Created:
4 years, 11 months ago by Brian Wilkerson
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I don't remember intentionally deciding to change the hierarchy for the element model, but it's ...
4 years, 11 months ago (2016-01-04 15:22:37 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-04 16:21:10 UTC) #3
Brian Wilkerson
4 years, 11 months ago (2016-01-04 16:22:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d86f7d29a8915a99fe6a59e3198120b95f06b70f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698