Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: test/cctest/compiler/test-run-bytecode-graph-builder.cc

Issue 1555063002: [Interpreter] Adds support for wide variant of load/store lookup slots. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/compiler/test-run-bytecode-graph-builder.cc
diff --git a/test/cctest/compiler/test-run-bytecode-graph-builder.cc b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
index be1fefeee52e9a338489251acd607680c3e76473..52ec6f3fde602e0e97493c42c9fafa5dca0658d0 100644
--- a/test/cctest/compiler/test-run-bytecode-graph-builder.cc
+++ b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
@@ -1038,6 +1038,8 @@ TEST(BytecodeGraphBuilderLookupSlot) {
{"return x;", {factory->NewNumber(12)}},
{"return obj.val;", {factory->NewNumber(3.1414)}},
{"return typeof x;", {factory->NewStringFromStaticChars("number")}},
+ {"return typeof dummy;",
+ {factory->NewStringFromStaticChars("undefined")}},
{"x = 23; return x;", {factory->NewNumber(23)}},
{"'use strict'; obj.val = 23.456; return obj.val;",
{factory->NewNumber(23.456)}}};
@@ -1056,6 +1058,54 @@ TEST(BytecodeGraphBuilderLookupSlot) {
}
+TEST(BytecodeGraphBuilderLookupSlotWide) {
+ HandleAndZoneScope scope;
+ Isolate* isolate = scope.main_isolate();
+ Zone* zone = scope.main_zone();
+ Factory* factory = isolate->factory();
+
+ const char* function_prologue =
+ "var f;"
+ "var x = 12;"
+ "y = 10;"
+ "var obj = {val:3.1414};"
+ "var z = 30;"
+ "function f1() {"
+ " var z = 20;"
+ " eval(\"function t() {";
+ const char* function_epilogue =
+ " }; f = t; t();\");"
+ "}"
+ "f1();";
+ std::ostringstream str;
+ str << "var y = 2.3; ";
+ for (int i = 1; i < 256; i++) {
+ str << "y = " << 2.3 + i << "; ";
+ }
+ std::string init_function_body = str.str();
+
+ std::pair<std::string, Handle<Object>> snippets[] = {
+ {init_function_body + "return x;", factory->NewNumber(12)},
+ {init_function_body + "return typeof x;",
+ factory->NewStringFromStaticChars("number")},
+ {init_function_body + "return x = 23;", factory->NewNumber(23)},
+ {"'use strict';" + init_function_body + "return obj.val = 23.456;",
+ factory->NewNumber(23.456)}};
+
+ size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
+ for (size_t i = 0; i < num_snippets; i++) {
+ ScopedVector<char> script(3072);
+ SNPrintF(script, "%s %s %s", function_prologue, snippets[i].first.c_str(),
+ function_epilogue);
+
+ BytecodeGraphTester tester(isolate, zone, script.start(), "t");
+ auto callable = tester.GetCallable<>();
+ Handle<Object> return_value = callable().ToHandleChecked();
+ CHECK(return_value->SameValue(*snippets[i].second));
+ }
+}
+
+
bool get_compare_result(Token::Value opcode, Handle<Object> lhs_value,
Handle<Object> rhs_value) {
switch (opcode) {

Powered by Google App Engine
This is Rietveld 408576698