Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java

Issue 155503004: Create a skeleton AppBannerManager class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding another call to onContentChanged Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
index 357b4fa7fbb3fbd22acc6dde60718e400c15180a..12f86f5f215c4be784258f073a85104caa6c308d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/TabBase.java
@@ -13,6 +13,7 @@ import android.view.View;
import org.chromium.base.CalledByNative;
import org.chromium.base.ObserverList;
+import org.chromium.chrome.browser.banners.AppBannerManager;
import org.chromium.chrome.browser.contextmenu.ChromeContextMenuItemDelegate;
import org.chromium.chrome.browser.contextmenu.ChromeContextMenuPopulator;
import org.chromium.chrome.browser.contextmenu.ContextMenuParams;
@@ -87,6 +88,9 @@ public abstract class TabBase implements NavigationClient {
/** InfoBar container to show InfoBars for this tab. */
private InfoBarContainer mInfoBarContainer;
+ /** Manages app banners shown for this tab. */
+ private AppBannerManager mAppBannerManager;
+
/** The sync id of the TabBase if session sync is enabled. */
private int mSyncId;
@@ -671,6 +675,12 @@ public abstract class TabBase implements NavigationClient {
} else {
mInfoBarContainer.onParentViewChanged(getId(), getContentView());
}
+
+ if (AppBannerManager.isEnabled() && mAppBannerManager == null) {
+ mAppBannerManager = new AppBannerManager(this);
+ }
+
+ for (TabObserver observer : mObservers) observer.onContentChanged(this);
}
/**
@@ -771,6 +781,8 @@ public abstract class TabBase implements NavigationClient {
assert mNativeTabAndroid != 0;
nativeDestroyWebContents(mNativeTabAndroid, deleteNativeWebContents);
+
+ for (TabObserver observer : mObservers) observer.onContentChanged(this);
Ted C 2014/02/13 03:57:50 hmm...this gives me the scares. At this point, na
gone 2014/02/13 05:01:16 Took it back out. Bringing popcorn for the fistic
}
/**

Powered by Google App Engine
This is Rietveld 408576698