Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1555023002: [turbofan] Add deopt point for InternalSetPrototype in VisitObjectLiteral. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add deopt point for InternalSetPrototype in VisitObjectLiteral. BUG=chromium:572409 LOG=n Committed: https://crrev.com/140f69d784b7f74bd1c0aad906945907839e79db Cr-Commit-Position: refs/heads/master@{#33078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -13 lines) Patch
M src/ast/ast.h View 1 chunk +9 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +5 lines, -1 line 0 comments Download
A test/mjsunit/compiler/regress-572409.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jarin
Could you take a look, please?
4 years, 11 months ago (2016-01-04 09:36:05 UTC) #2
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-04 09:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1555023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1555023002/1
4 years, 11 months ago (2016-01-04 09:52:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 09:54:17 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 09:55:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/140f69d784b7f74bd1c0aad906945907839e79db
Cr-Commit-Position: refs/heads/master@{#33078}

Powered by Google App Engine
This is Rietveld 408576698