chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h - Issue 1554983002: Build chrome.input.ime.* API in GN mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.h

Issue 1554983002: Build chrome.input.ime.* API in GN mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove class InputImeEventRouter from input_ime_api.h to input_ime_api_chromeos/nonchromeos.h Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.h ('K') | « chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc ('k') | chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.
	Devlin 2016/01/05 18:39:07 Not 2015 Not 2015 Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > Not 2015 Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_API_INPUT_IME_INPUT_IME_API_NONCHROMEOS_H_

	6 #define CHROME_BROWSER_EXTENSIONS_API_INPUT_IME_INPUT_IME_API_NONCHROMEOS_H_

	7

	8 #include "extensions/browser/extension_function.h"

	9

	10 namespace extensions {
	Devlin 2016/01/05 18:39:07 \n \n Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > \n Done.
	11 class InputImeEventRouter {

	12 public:

	13 explicit InputImeEventRouter(Profile* profile);

	14 ~InputImeEventRouter();

	15

	16 // Called when a key event was handled.

	17 void OnKeyEventHandled(const std::string& extension_id,

	18 const std::string& request_id,

	19 bool handled);

	20

	21 std::string AddRequest(

	22 const std::string& component_id,

	23 ui::IMEEngineHandlerInterface::KeyEventDoneCallback& key_data);

	24

	25 private:

	26 typedef std::map<
	Devlin 2016/01/05 18:39:07 using using Devlin 2016/01/05 18:39:07 #include <map> #include <map> Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > using Done. Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > #include <map> Done.
	27 std::string,

	28 std::pair<std::string,
	Devlin 2016/01/05 18:39:07 #include <utility> #include <utility> Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > #include <utility> Done.
	29 ui::IMEEngineHandlerInterface::KeyEventDoneCallback>>

	30 RequestMap;

	31

	32 // The id of the all registered extensions.

	33 std::vector<std::string> extension_ids_;
	Devlin 2016/01/05 18:39:07 #include <string> #include <string> Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > #include <string> Done.
	34

	35 unsigned int next_request_id_;

	36 RequestMap request_map_;

	37 Profile* profile_;
	Devlin 2016/01/05 18:39:06 forward declare forward declare Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:06, Devlin wrote: > forward declare Done.
	38
	Devlin 2016/01/05 18:39:07 base/macros base/macros Azure Wei 2016/01/06 06:53:47 Done. Show quoted text On 2016/01/05 18:39:07, Devlin wrote: > base/macros Done.
	39 DISALLOW_COPY_AND_ASSIGN(InputImeEventRouter);

	40 };

	41

	42 } // namespace extensions

	43

	44 #endif // CHROME_BROWSER_EXTENSIONS_API_INPUT_IME_INPUT_IME_API_NONCHROMEOS_H_

OLD	NEW