Noticed a crash in BrowserRenderProcessHost::SendUserScriptsUpdate due to usi...

Noticed a crash in BrowserRenderProcessHost::SendUserScriptsUpdate due to using channel_->send() directly (instead of BrowserRenderProcessHost::Send() which checks whether channel_ is created).

It looks like this can happen during BrowserRenderProcessHost creation since the brph signs up for notifications at construction but only creates channel_ in its Init() method. 

BUG=http://b/15384



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20627

[robertshield, 2009-07-14 15:45:55]

Potential fix for http://code.google.com/p/chromium/issues/detail?id=15384.

Could also be achieved by only signing up for USER_SCRIPTS_UPDATED notifications
after channel_ creation.

[Evan Martin, 2009-07-14 15:48:36]

In the circumstance where this races, is the message send just dropped?  Does
that cause other things to break?

Also, your bug URL is nonsense. ;)

[robert, 2009-07-14 16:03:41]

On Tue, Jul 14, 2009 at 11:48 AM, <evan@chromium.org> wrote:

> In the circumstance where this races, is the message send just dropped?
> Does that cause other things to break?
>

It may well. I sent this off rather quickly (the crash was in my way), and
the patch does cause the message to get dropped when it can't be sent along.
I know almost nothing about user scripts and how they start up, so it might
be necessary to queue the message up somewhere pending channel creation.

It might also be necessary to ignore this patch and do something completely
different.



>
> Also, your bug URL is nonsense. ;)
>

Copy / pasted from the browser ;-) Here: http://crbug.com/15384, now my URL
is shorter than yours! So there!


>
>
> http://codereview.chromium.org/155498
>

[Aaron Boodman, 2009-07-14 16:15:13]

lgtm

Awesome, I'm happy somebody saw this in action. I am OK with this fix. Yes, we
will drop some updates on the floor, but we pick them up again on renderer
creation (that is the same case as creating a new renderer after user scripts
are loaded).