Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1554963003: Add UseCounter for InputDeviceCapabilities.firesTouchEvents (Closed)

Created:
4 years, 11 months ago by Rick Byers
Modified:
4 years, 11 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, tdresser
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounter for InputDeviceCapabilities.firesTouchEvents BUG=476530 Committed: https://crrev.com/c24c6c85bc5a67ef280fa278a6a3436403d7e011 Cr-Commit-Position: refs/heads/master@{#367683}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 2 comments Download

Messages

Total messages: 19 (9 generated)
Rick Byers
Lan, PTAL I figured we should probably have this to help track adoption / help ...
4 years, 11 months ago (2016-01-04 18:50:38 UTC) #3
Rick Byers
+rkaplow for histograms.xml OWNERS https://codereview.chromium.org/1554963003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1554963003/diff/1/tools/metrics/histograms/histograms.xml#newcode64915 tools/metrics/histograms/histograms.xml:64915: + <int value="1097" label="V8RegExpPrototypeToString"/> Note ...
4 years, 11 months ago (2016-01-04 18:54:14 UTC) #5
Dan Ehrenberg
https://codereview.chromium.org/1554963003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1554963003/diff/1/tools/metrics/histograms/histograms.xml#newcode64915 tools/metrics/histograms/histograms.xml:64915: + <int value="1097" label="V8RegExpPrototypeToString"/> On 2016/01/04 at 18:54:14, Rick ...
4 years, 11 months ago (2016-01-04 19:03:03 UTC) #7
lanwei
On 2016/01/04 18:50:38, Rick Byers wrote: > Lan, PTAL > I figured we should probably ...
4 years, 11 months ago (2016-01-04 20:13:51 UTC) #8
rkaplow
lgtm
4 years, 11 months ago (2016-01-05 15:44:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554963003/1
4 years, 11 months ago (2016-01-05 16:09:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/155049)
4 years, 11 months ago (2016-01-05 20:35:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554963003/1
4 years, 11 months ago (2016-01-05 20:44:03 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 23:14:38 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 23:15:27 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c24c6c85bc5a67ef280fa278a6a3436403d7e011
Cr-Commit-Position: refs/heads/master@{#367683}

Powered by Google App Engine
This is Rietveld 408576698