third_party/WebKit/Source/core/svg/SVGUseElement.cpp - Issue 1554903002: EventSender<T> singletons are better off on the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

Issue 1554903002: EventSender<T> singletons are better off on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove no-op cancelEvent()s Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGUseElement.h ('k') | third_party/WebKit/Source/core/svg/animation/SVGSMILElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGUseElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

index 41ad6c1b53566293a7d133562e75fdccf1ab2b9c..cb20a0a09fca35dc99b977b64679ab0bf2fda8b8 100644

--- a/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGUseElement.cpp

@@ -46,8 +46,8 @@ namespace blink {

static SVGUseEventSender& svgUseLoadEventSender()

{

- DEFINE_STATIC_LOCAL(SVGUseEventSender, sharedLoadEventSender, (EventTypeNames::load));

- return sharedLoadEventSender;

+ DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<SVGUseEventSender>, sharedLoadEventSender, (SVGUseEventSender::create(EventTypeNames::load)));

+ return *sharedLoadEventSender;

}

inline SVGUseElement::SVGUseElement(Document& document)

@@ -82,8 +82,8 @@ SVGUseElement::~SVGUseElement()

#if !ENABLE(OILPAN)

clearShadowTree();

cancelShadowTreeRecreation();

-#endif

svgUseLoadEventSender().cancelEvent(this);

+#endif

}

DEFINE_TRACE(SVGUseElement)