Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/svg/SVGStyleElement.cpp

Issue 1554903002: EventSender<T> singletons are better off on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove no-op cancelEvent()s Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGStyleElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp b/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp
index d53822eb19dd0ee951807741e406addce9090403..b27ec3f09cce37857bffcd78c4268f15dbd6ea14 100644
--- a/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGStyleElement.cpp
@@ -31,8 +31,8 @@ namespace blink {
static SVGStyleEventSender& styleErrorEventSender()
{
- DEFINE_STATIC_LOCAL(SVGStyleEventSender, sharedErrorEventSender, (EventTypeNames::error));
- return sharedErrorEventSender;
+ DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<SVGStyleEventSender>, sharedErrorEventSender, (SVGStyleEventSender::create(EventTypeNames::error)));
+ return *sharedErrorEventSender;
}
inline SVGStyleElement::SVGStyleElement(Document& document, bool createdByParser)
@@ -45,9 +45,9 @@ SVGStyleElement::~SVGStyleElement()
{
#if !ENABLE(OILPAN)
StyleElement::clearDocumentData(document(), this);
-#endif
styleErrorEventSender().cancelEvent(this);
+#endif
}
PassRefPtrWillBeRawPtr<SVGStyleElement> SVGStyleElement::create(Document& document, bool createdByParser)
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGStyleElement.h ('k') | third_party/WebKit/Source/core/svg/SVGUseElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698