Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp

Issue 1554903002: EventSender<T> singletons are better off on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove no-op cancelEvent()s Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
index edb3afbfe97901e1636793279d354e4ae24ae305..eb583d7504e5d41f46dcb241af0bf5a30781b495 100644
--- a/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSourceElement.cpp
@@ -42,8 +42,8 @@ using namespace HTMLNames;
static SourceEventSender& sourceErrorEventSender()
{
- DEFINE_STATIC_LOCAL(SourceEventSender, sharedErrorEventSender, (EventTypeNames::error));
- return sharedErrorEventSender;
+ DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<SourceEventSender>, sharedErrorEventSender, (SourceEventSender::create(EventTypeNames::error)));
+ return *sharedErrorEventSender;
}
class HTMLSourceElement::Listener final : public MediaQueryListListener {
@@ -76,8 +76,8 @@ DEFINE_NODE_FACTORY(HTMLSourceElement)
HTMLSourceElement::~HTMLSourceElement()
{
- sourceErrorEventSender().cancelEvent(this);
#if !ENABLE(OILPAN)
+ sourceErrorEventSender().cancelEvent(this);
m_listener->clearElement();
#endif
}
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSourceElement.h ('k') | third_party/WebKit/Source/core/html/HTMLStyleElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698