Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp

Issue 1554903002: EventSender<T> singletons are better off on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove no-op cancelEvent()s Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
index 920052643777d9a0a7f9570e23b0622f097e686b..3ef235336ddb72d7b56ae287c20d55df8ca11d95 100644
--- a/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLDetailsElement.cpp
@@ -73,8 +73,8 @@ private:
static DetailsEventSender& detailsToggleEventSender()
{
- DEFINE_STATIC_LOCAL(DetailsEventSender, sharedToggleEventSender, (EventTypeNames::toggle));
- return sharedToggleEventSender;
+ DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<DetailsEventSender>, sharedToggleEventSender, (DetailsEventSender::create(EventTypeNames::toggle)));
+ return *sharedToggleEventSender;
}
PassRefPtrWillBeRawPtr<HTMLDetailsElement> HTMLDetailsElement::create(Document& document)
@@ -93,7 +93,9 @@ HTMLDetailsElement::HTMLDetailsElement(Document& document)
HTMLDetailsElement::~HTMLDetailsElement()
{
+#if !ENABLE(OILPAN)
detailsToggleEventSender().cancelEvent(this);
+#endif
}
void HTMLDetailsElement::dispatchPendingEvent(DetailsEventSender* eventSender)
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLDetailsElement.h ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698