Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webkit/glue/devtools/js/tests.js

Issue 155482: Fix the ConsoleLog test and enable it. It was previously disabled because Web... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/debugger/devtools_sanity_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/devtools/js/tests.js
===================================================================
--- webkit/glue/devtools/js/tests.js (revision 20588)
+++ webkit/glue/devtools/js/tests.js (working copy)
@@ -482,7 +482,7 @@
var index = 0;
var test = this;
- var assertNext = function(line, message, opt_level, opt_count, opt_substr) {
+ var assertNext = function(line, message, opt_class, opt_count, opt_substr) {
var elem = messages[index++].toMessageElement();
var clazz = elem.getAttribute('class');
var expectation = (opt_count || '') + 'console_test_page.html:' +
@@ -492,25 +492,25 @@
} else {
test.assertEquals(expectation, elem.textContent);
}
- if (opt_level) {
- test.assertContains(clazz, 'console-' + opt_level + '-level');
+ if (opt_class) {
+ test.assertContains(clazz, 'console-' + opt_class);
}
};
- assertNext('5', 'log', 'log');
- assertNext('7', 'debug', 'log');
- assertNext('9', 'info', 'log');
- assertNext('11', 'warn', 'warning');
- assertNext('13', 'error', 'error');
+ assertNext('5', 'log', 'log-level');
+ assertNext('7', 'debug', 'log-level');
+ assertNext('9', 'info', 'log-level');
+ assertNext('11', 'warn', 'warning-level');
+ assertNext('13', 'error', 'error-level');
assertNext('15', 'Message format number 1, 2 and 3.5');
assertNext('17', 'Message format for string');
assertNext('19', 'Object Object');
- assertNext('22', 'repeated', 'log', 5);
+ assertNext('22', 'repeated', 'log-level', 5);
assertNext('26', 'count: 1');
assertNext('26', 'count: 2');
assertNext('29', 'group', 'group-title');
index++;
- assertNext('33', 'timer:', 'log', '', true);
+ assertNext('33', 'timer:', 'log-level', '', true);
};
« no previous file with comments | « chrome/browser/debugger/devtools_sanity_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698