Issue 155482: Fix the ConsoleLog test and enable it. It was previously disabled because Web...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155482: Fix the ConsoleLog test and enable it. It was previously disabled because Web... (Closed)

Created:
11 years, 5 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
pfeldman, yurys

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the ConsoleLog test and enable it. It was previously disabled because WebKit change http://trac.webkit.org/changeset/45786 had split the 'type' and 'level' parameters of the ConsoleMessage into 2 separate parameters, which changed the way CSS styles are formatted for messages in Inspector front-end. Updated test expectations. BUG=16684 TEST=the test DevToolsSanityTest.TestConsoleLog is enabled by this CL Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20609

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	chrome/browser/debugger/devtools_sanity_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/devtools/js/tests.js	View		2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

The 'console-group-title-level' CSS style is now just 'console-group-title' since it is not a 'level' anymore, ...

11 years, 5 months ago (2009-07-14 03:27:10 UTC) #1

Dmitry Titov

Oh, I only need one (either) of you guys to review this CL :-)

11 years, 5 months ago (2009-07-14 03:28:44 UTC) #2

LGTM, thanks for fixing this.

Expand Messages | Collapse Messages