Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1554793002: Add a new test certificate for *.example.org as wildcard.pem (Closed)

Created:
4 years, 11 months ago by Ryan Hamilton
Modified:
4 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new test certificate for *.example.org as wildcard.pem Committed: https://crrev.com/4477e4b73ef3d3e25764825c910de02695af6c0b Cr-Commit-Position: refs/heads/master@{#367212}

Patch Set 1 #

Patch Set 2 : Fix README #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M net/data/ssl/certificates/README View 1 1 chunk +4 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/wildcard.pem View 1 chunk +110 lines, -0 lines 0 comments Download
M net/data/ssl/scripts/ee.cnf View 2 chunks +6 lines, -0 lines 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 3 chunks +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (6 generated)
Ryan Hamilton
How does this look?
4 years, 11 months ago (2015-12-30 20:38:01 UTC) #2
Ryan Sleevi
lgtm
4 years, 11 months ago (2015-12-30 20:50:17 UTC) #3
Ryan Sleevi
Could you also poke net/data/ssl/certificates/README :)
4 years, 11 months ago (2015-12-30 20:50:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554793002/1
4 years, 11 months ago (2015-12-30 20:51:02 UTC) #6
Ryan Hamilton
On 2015/12/30 20:50:33, Ryan Sleevi wrote: > Could you also poke net/data/ssl/certificates/README :) Good idea. ...
4 years, 11 months ago (2015-12-30 21:11:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554793002/20001
4 years, 11 months ago (2015-12-30 23:22:19 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-31 00:31:29 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 00:32:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4477e4b73ef3d3e25764825c910de02695af6c0b
Cr-Commit-Position: refs/heads/master@{#367212}

Powered by Google App Engine
This is Rietveld 408576698