Issue 155479: Make use of the new Js Template i18n for print domui...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155479: Make use of the new Js Template i18n for print domui... (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews), M-A Ruel

CC:
chromium-reviews_googlegroups.com, Sverrir

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Make use of the new Js Template i18n for print domui Provides a simpler js template engine for print tab which is optimized better than JsTemplate. BUG=173, 947 TEST=print page loads fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20702

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	chrome/browser/dom_ui/print_ui.cc	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
	M	chrome/browser/resources/print_tab.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

today arv submitted a the new jstemplate i18n change, and would be nicer to use ...

11 years, 5 months ago (2009-07-14 02:29:26 UTC) #1

arv (Not doing code reviews)

11 years, 5 months ago (2009-07-14 18:20:33 UTC) #2

LGTM

Sorry for missing this one

http://codereview.chromium.org/155479/diff/1/2
File chrome/browser/resources/print_tab.html (right):

http://codereview.chromium.org/155479/diff/1/2#newcode2
Line 2: <html i18n-values="dir:textdirection;">
you can skip the trailing semi colon here.

http://codereview.chromium.org/155479/diff/1/2#newcode15
Line 15: <p>Borat says &quot;Very nice!&quot;</p>
hehe

Expand Messages | Collapse Messages