Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 155479: Make use of the new Js Template i18n for print domui... (Closed)

Created:
11 years, 5 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, Sverrir
Visibility:
Public.

Description

Make use of the new Js Template i18n for print domui Provides a simpler js template engine for print tab which is optimized better than JsTemplate. BUG=173, 947 TEST=print page loads fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20702

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/dom_ui/print_ui.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_tab.html View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mohamed Mansour
today arv submitted a the new jstemplate i18n change, and would be nicer to use ...
11 years, 5 months ago (2009-07-14 02:29:26 UTC) #1
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-14 18:20:33 UTC) #2
LGTM

Sorry for missing this one

http://codereview.chromium.org/155479/diff/1/2
File chrome/browser/resources/print_tab.html (right):

http://codereview.chromium.org/155479/diff/1/2#newcode2
Line 2: <html i18n-values="dir:textdirection;">
you can skip the trailing semi colon here.

http://codereview.chromium.org/155479/diff/1/2#newcode15
Line 15: <p>Borat says &quot;Very nice!&quot;</p>
hehe

Powered by Google App Engine
This is Rietveld 408576698