Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1554733003: Convert Pass()→std::move() in //tools/cygprofile (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
pasko, Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //tools/cygprofile (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=pasko@chromium.org Committed: https://crrev.com/7680f3744f4dca188574d8182deee383d8d535cc Cr-Commit-Position: refs/heads/master@{#367202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/cygprofile/cygprofile_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
Something else that doesn't appear to build in the default config. I've filed https://crbug.com/573326 for ...
4 years, 11 months ago (2015-12-30 22:57:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554733003/1
4 years, 11 months ago (2015-12-30 22:57:47 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 11 months ago (2015-12-30 23:13:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 23:19:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1554733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1554733003/1
4 years, 11 months ago (2015-12-30 23:24:45 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 23:29:38 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 23:30:32 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7680f3744f4dca188574d8182deee383d8d535cc
Cr-Commit-Position: refs/heads/master@{#367202}

Powered by Google App Engine
This is Rietveld 408576698